This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: use dnsaddr for bootstrap nodes#3370
Merged
achingbrain merged 2 commits intomasterfrom Nov 6, 2020
Merged
Conversation
vasco-santos
force-pushed
the
chore/use-dns-addr-fot-bootstrap
branch
from
174d972 to
bd752df
Compare
vasco-santos
commented
Nov 5, 2020
|
|
||
| module.exports = { | ||
| bundlesize: { maxSize: '518kB' }, | ||
| bundlesize: { maxSize: '520kB' }, |
Member
Author
There was a problem hiding this comment.
Need to increase due to the addition of the dns-over-http-resolver module in multiaddr, which also comes with receptacle.
achingbrain
approved these changes
Nov 6, 2020
Contributor
|
@vasco-santos @achingbrain it looks like we missed the update of these for the Node.js config, they should get updated there, that config is using some outdated Peer Ids. |
Member
Author
|
yes, I will remove the SoL multiaddrs as well |
achingbrain
pushed a commit
that referenced
this pull request
Nov 12, 2020
Replaces `SoL-arnet` bootstrap nodes from Node.js config to the new `dnsaddr` per #3370 (comment) and libp2p/js-libp2p-bootstrap#98 These new addresses resolve into DNS TXT records with tcp and wss based addresses for each peer (with `ipv4` and `ipv6`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new
dnsaddrmultiaddrs for browser bootstrapping peers per libp2p/js-libp2p#772 and libp2p/js-libp2p#782cc @mburns